AnonHxy commented on code in PR #4176:
URL: https://github.com/apache/bookkeeper/pull/4176#discussion_r1452512335
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java:
##########
@@ -71,6 +73,11 @@ protected void processPacket() {
int errorCode = BookieProtocol.EOK;
long startTimeNanos = MathUtils.nowInNano();
ByteBuf data = null;
+ if (readTimeoutNanos >= 0 && startTimeNanos - enqueueNanos >
readTimeoutNanos) {
Review Comment:
```suggestion
if (readTimeoutNanos > 0 && startTimeNanos - enqueueNanos >
readTimeoutNanos) {
```
I thinks <=0 for disabled is better:), `startTimeNanos - enqueueNanos > 0 `
doesn't make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
