315157973 commented on code in PR #4176:
URL: https://github.com/apache/bookkeeper/pull/4176#discussion_r1461870011
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -2030,7 +2031,23 @@ public boolean isReadWorkerThreadsThrottlingEnabled() {
return getBoolean(READ_WORKER_THREADS_THROTTLING_ENABLED, true);
}
+ /**
+ * Set timout millis for pending read request.
+ * @param timeoutMillis timout millis of pending read request.
+ * @return server configuration
+ */
+ public ServerConfiguration setReadEntryPendingTimeoutMillis(long
timeoutMillis) {
+ setProperty(READ_ENTRY_PENDING_TIMEOUT_MILLIS, timeoutMillis);
+ return this;
+ }
+ /**
+ * Get timout millis for pending read request.
+ * @return timout millis
+ */
+ public long getReadEntryPendingTimeoutMillis() {
Review Comment:
The server should set a maximum timeout, and we cannot rely on the time set
by the client.
Like Zookeeper, the server can also set a maximum Session timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
