tomjo commented on code in PR #4208:
URL: https://github.com/apache/bookkeeper/pull/4208#discussion_r1497121185
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/MetricsService.java:
##########
@@ -65,6 +67,7 @@ public HttpServiceResponse handle(HttpServiceRequest request)
throws Exception {
statsProvider.writeAllMetrics(writer);
writer.flush();
response.setCode(StatusCode.OK);
+ response.setContentType(PROMETHEUS_CONTENT_TYPE_004);
Review Comment:
This will require dependency changes wasn't sure of that. I can either
change the scope of the org.apache.bookkeeper.stats:prometheus-metrics-provider
artifact to non-test or add an explicit dependency on
io.prometheus:simpleclient_common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
