eolivelli commented on code in PR #4208:
URL: https://github.com/apache/bookkeeper/pull/4208#discussion_r1512253263


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/MetricsService.java:
##########
@@ -65,6 +66,7 @@ public HttpServiceResponse handle(HttpServiceRequest request) 
throws Exception {
             statsProvider.writeAllMetrics(writer);
             writer.flush();
             response.setCode(StatusCode.OK);
+            response.setContentType(TextFormat.CONTENT_TYPE_004);

Review Comment:
   we really have to add a new jar only for a string constant ?
   I think that it is overkill
   
   can we drop the jar and use a normal string here ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to