lhotari commented on code in PR #4377:
URL: https://github.com/apache/bookkeeper/pull/4377#discussion_r1618312589
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/BookKeeperBuildersOpenLedgerTest.java:
##########
@@ -58,20 +56,20 @@ public class BookKeeperBuildersOpenLedgerTest extends
MockBookKeeperTestCase {
private boolean withRecovery;
- public BookKeeperBuildersOpenLedgerTest(boolean withRecovery) {
+ public void initBookKeeperBuildersOpenLedgerTest(boolean withRecovery) {
this.withRecovery = withRecovery;
}
- @Parameterized.Parameters(name = "withRecovery:({0})")
public static Collection<Object[]> data() {
return Arrays.asList(new Object[][]{
{true},
{false}
});
}
- @Test
- public void testOpenLedger() throws Exception {
+ @MethodSource("data")
Review Comment:
In junit5, it's better to use `@ValueSource(booleans = {true, false})` for
cases where there's a single boolean parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
