liangyuanpeng commented on code in PR #4377:
URL: https://github.com/apache/bookkeeper/pull/4377#discussion_r1639563847
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java:
##########
@@ -264,6 +267,7 @@ private DigestManager getDigestType(long ledgerId) throws
GeneralSecurityExcepti
UnpooledByteBufAllocator.DEFAULT, false);
}
+ @AfterEach
@After
Review Comment:
how about add some todo here: `// TODO: delete @Before when only run with
junit5`
##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeeperTestCase.java:
##########
@@ -141,6 +143,7 @@ public MockEntry(byte[] payload, long lastAddConfirmed) {
}
+ @BeforeEach
@Before
Review Comment:
how about add some todo here: `// TODO: delete @Before when only run with
junit5`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
