lhotari commented on code in PR #4480:
URL: https://github.com/apache/bookkeeper/pull/4480#discussion_r1718862778
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java:
##########
@@ -198,7 +198,7 @@ private RocksDB initializeRocksDBWithBookieConf(String
basePath, String subPath,
int blockSize = conf.getInt(ROCKSDB_BLOCK_SIZE, 64 * 1024);
int bloomFilterBitsPerKey =
conf.getInt(ROCKSDB_BLOOM_FILTERS_BITS_PER_KEY, 10);
boolean lz4CompressionEnabled =
conf.getBoolean(ROCKSDB_LZ4_COMPRESSION_ENABLED, true);
- int formatVersion = conf.getInt(ROCKSDB_FORMAT_VERSION, 2);
+ int formatVersion = conf.getInt(ROCKSDB_FORMAT_VERSION, 5);
Review Comment:
This code doesn't get used at all if `conf/entry_location_rocksdb.conf` or
`conf/ledger_metadata_rocksdb.conf` files exist. That was changed in Bookkeeper
4.15 in https://github.com/apache/bookkeeper/pull/3056 (Pulsar 2.11,
https://github.com/apache/pulsar/pull/15142).
@eolivelli Is your intention to print out the effective database version? I
think it might be challenging to get it right since I believe that the given
format version will only be used for new databases. For existing databases, the
format is whatever it was at creation time. Just wondering if the log message
would cause confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
