lhotari commented on code in PR #4480:
URL: https://github.com/apache/bookkeeper/pull/4480#discussion_r1719679373
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java:
##########
@@ -198,7 +198,7 @@ private RocksDB initializeRocksDBWithBookieConf(String
basePath, String subPath,
int blockSize = conf.getInt(ROCKSDB_BLOCK_SIZE, 64 * 1024);
int bloomFilterBitsPerKey =
conf.getInt(ROCKSDB_BLOOM_FILTERS_BITS_PER_KEY, 10);
boolean lz4CompressionEnabled =
conf.getBoolean(ROCKSDB_LZ4_COMPRESSION_ENABLED, true);
- int formatVersion = conf.getInt(ROCKSDB_FORMAT_VERSION, 2);
+ int formatVersion = conf.getInt(ROCKSDB_FORMAT_VERSION, 5);
Review Comment:
Let's handle the possible logging separately. Bookkeeper 4.14 uses RocksDB
6.29 which supports format_version=5 (introduced in [RocksDB
6.6.0](https://github.com/facebook/rocksdb/releases/tag/v6.6.3)).
Before RocksDB 6.29, version 6.16 was used. format_version=5 support has
been around for a long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
