lhotari commented on PR #4422: URL: https://github.com/apache/bookkeeper/pull/4422#issuecomment-2295682175
> @lhotari It is set to `2` > > * https://github.com/apache/bookkeeper/blob/8890a61418e3961e0000108b3c2e8ea176691e5f/conf/entry_location_rocksdb.conf.default#L62-L63 > * https://github.com/apache/pulsar/blob/7636e8989f4d3fc24fce69a356d54e1c550945ed/conf/entry_location_rocksdb.conf#L61-L62 @hangc0276 Yes, you are right that format_version should already be set to 2. I was assuming that the ledger metadata database would have been the problem. However, when `conf/entry_location_rocksdb.conf` is missing, the format_version set in code would get used. (logic https://github.com/apache/bookkeeper/blob/f048e7a3b127cfa3a7e9761d589225f078d6712c/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java#L126-L140) By default in BK, the file is missing since the provide file is `conf/entry_location_rocksdb.conf.default` and that has no impact. However, since format_version 2 is ancient, you never know if it starts causing problems when continuing to use it with RocskDB 9.x+. I haven't yet investigated the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
