StevenLuMT commented on code in PR #4602:
URL: https://github.com/apache/bookkeeper/pull/4602#discussion_r2085762263
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/ListActiveLedgersCommand.java:
##########
@@ -161,15 +155,17 @@ public void handler(ServerConfiguration bkConf,
ActiveLedgerFlags cmdFlags)
});
}
- public void printActiveLedgerOnEntryLog(long logId, List<Long>
activeLedgers){
- if (activeLedgers.size() == 0){
+ public void printActiveLedgerOnEntryLog(long logId, EntryLogMetadata
entryLogMetadata) {
Review Comment:
Suggest adding a testcase to cover this new method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
