StevenLuMT commented on code in PR #4602:
URL: https://github.com/apache/bookkeeper/pull/4602#discussion_r2085759989
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/ReadLogMetadataCommand.java:
##########
@@ -131,8 +131,7 @@ private void printEntryLogMetadata(ServerConfiguration
conf, long logId) throws
LOG.info("Print entryLogMetadata of entrylog {} ({}.log)", logId,
Long.toHexString(logId));
initEntryLogger(conf);
EntryLogMetadata entryLogMetadata =
entryLogger.getEntryLogMetadata(logId);
- LOG.info("entryLogId: {}, remaining size: {}, total size: {}, usage:
{}", entryLogMetadata.getEntryLogId(),
- entryLogMetadata.getRemainingSize(),
entryLogMetadata.getTotalSize(), entryLogMetadata.getUsage());
+ LOG.info("entryLogId: {}, total size: {}",
entryLogMetadata.getEntryLogId(), entryLogMetadata.getTotalSize());
Review Comment:
Why do we need to modify this part of the log? Is there something wrong?
If the result of entryLogMetadata.getRemainingSize() is wrong, should we fix
it as well instead of directly avoiding the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
