nodece commented on code in PR #4645:
URL: https://github.com/apache/bookkeeper/pull/4645#discussion_r2250648130
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -114,6 +114,7 @@ public class ServerConfiguration extends
AbstractConfiguration<ServerConfigurati
protected static final String GC_OVERREPLICATED_LEDGER_WAIT_TIME =
"gcOverreplicatedLedgerWaitTime";
protected static final String
GC_OVERREPLICATED_LEDGER_MAX_CONCURRENT_REQUESTS =
"gcOverreplicatedLedgerMaxConcurrentRequests";
+ protected static final String GC_ZK_OP_RATE_LIMIT = "gcZkOpRateLimit";
Review Comment:
Have you considered using `gcMetadataOpRateLimit` instead? The underlying
metadata store could be ZooKeeper, etcd, or something else, so using a more
general name rather than one tied to a specific implementation is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
