Copilot commented on code in PR #4645:
URL: https://github.com/apache/bookkeeper/pull/4645#discussion_r2252918684
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -481,6 +482,24 @@ public ServerConfiguration
setGcOverreplicatedLedgerMaxConcurrentRequests(
return this;
}
+ /**
+ * Get the rate limit of zookeeper operations in garbage collection.
+ * @return
Review Comment:
The @return annotation is missing a description. It should specify what is
returned, e.g., '@return the rate limit for ZooKeeper operations in garbage
collection (operations per second)'.
```suggestion
* Get the rate limit of ZooKeeper operations in garbage collection.
* @return the rate limit for ZooKeeper operations in garbage collection
(operations per second)
```
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -481,6 +482,24 @@ public ServerConfiguration
setGcOverreplicatedLedgerMaxConcurrentRequests(
return this;
}
+ /**
+ * Get the rate limit of zookeeper operations in garbage collection.
+ * @return
+ */
+ public int getGcZkOpRateLimit() {
+ return this.getInt(GC_ZK_OP_RATE_LIMIT, 1000);
+ }
+
+ /**
+ * Set the rate limit of zookeeper operations in garbage collection.
+ * @param gcRateLimit
+ * @return
Review Comment:
The @return annotation is missing a description. It should specify what is
returned, e.g., '@return this ServerConfiguration instance for method chaining'.
```suggestion
* @param gcRateLimit the rate limit for zookeeper operations in garbage
collection
* @return this ServerConfiguration instance for method chaining
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
