eolivelli commented on code in PR #4661:
URL: https://github.com/apache/bookkeeper/pull/4661#discussion_r2314584847
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java:
##########
@@ -1151,11 +1154,19 @@ public OfLong getListOfEntriesOfLedger(long ledgerId)
throws IOException {
"getListOfEntriesOfLedger method is currently unsupported for
SingleDirectoryDbLedgerStorage");
}
- private LedgerDirsManager.LedgerDirsListener getLedgerDirsListener() {
+ private LedgerDirsManager.LedgerDirsListener getLedgerDirsListener(String
diskPath) {
Review Comment:
Why not creating a static inner class instead of this anonymous class ??
Then we add unit tests for the new class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
