liangyepianzhou commented on code in PR #4661:
URL: https://github.com/apache/bookkeeper/pull/4661#discussion_r2315155331
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/SingleDirectoryDbLedgerStorage.java:
##########
@@ -1151,11 +1154,19 @@ public OfLong getListOfEntriesOfLedger(long ledgerId)
throws IOException {
"getListOfEntriesOfLedger method is currently unsupported for
SingleDirectoryDbLedgerStorage");
}
- private LedgerDirsManager.LedgerDirsListener getLedgerDirsListener() {
+ private LedgerDirsManager.LedgerDirsListener getLedgerDirsListener(String
diskPath) {
Review Comment:
Changing LedgerDirsListener from an anonymous class to a member variable
still doesn’t seem to identify which disk SingleDirectoryDbLedgerStorage is
responsible for writing data to.
We also need to modify the LedgerDirsListener interface to expose the disk
address it’s in charge of, so that we can carry out testing.
By comparison, directly exposing the addresses of the ledger disk and the
index disk might be a more straightforward way to indicate what
SingleDirectoryDbLedgerStorage is responsible for.
If my understanding is off, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
