gtristan commented on PR #1856: URL: https://github.com/apache/buildstream/pull/1856#issuecomment-1668865464
Hi, Thanks for this fix ! Can we please put this new test somewhere else instead of a new file named `regression.py` ? (a large portion of our tests stem from regressions, yet we do not name them as such ;-) ). In this case, the issue itself is that local sources do not store refs, and as such they leave gaps in the `project.refs`, causing `IndexErrors` to occur when tracking. I think it's safe to say that this test is related to *storing refs in project.refs* when there is a lacking *ref*, as such I think it would be good to have this test in `tests/project/format.py` where we do preliminary testing on `project.refs`, and perhaps we could name the test `test_project_refs_gap()` and explain in a comment that this tests a gap in the `project.refs` file due to the `local` source not producing a ref. Noting the issue in the comments around the added test case is also appreciated :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
