juergbi commented on code in PR #1879:
URL: https://github.com/apache/buildstream/pull/1879#discussion_r1424429574
##########
src/buildstream/_remotespec.py:
##########
@@ -112,6 +113,9 @@ def __init__(
# The grpc credentials object
self._credentials: Optional[ChannelCredentials] = None
+ # Various connection parameters for grpc connection
+ self._connection_config: Optional[int] = connection_config
Review Comment:
```suggestion
self._connection_config: Optional[MappingNode] = connection_config
```
##########
src/buildstream/_remotespec.py:
##########
@@ -176,6 +181,13 @@ def credentials(self) -> ChannelCredentials:
)
return self._credentials
+ # grpc keepalive timeout
+ #
+ @property
+ def keepalive_time(self) -> Optional[int]:
+ if self._connection_config:
+ return self._connection_config.get_int("keepalive-timeout", None)
Review Comment:
```suggestion
return self._connection_config.get_int("keepalive-time", None)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
