abderrahim commented on code in PR #1879:
URL: https://github.com/apache/buildstream/pull/1879#discussion_r1425760907
##########
src/buildstream/_remotespec.py:
##########
@@ -227,10 +240,11 @@ def new_from_node(
server_cert: Optional[str] = None
client_key: Optional[str] = None
client_cert: Optional[str] = None
+ keepalive_config: Optional[MappingNode] = None
Review Comment:
linter is complaining this is unused.
##########
src/buildstream/_cas/casremote.py:
##########
@@ -13,6 +13,7 @@
#
import grpc
+from google.protobuf.duration_pb2 import Duration
Review Comment:
I don't know if it's fatal, but linter is complaining about this. Maybe we
need to add some dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
