sophie-h commented on code in PR #62: URL: https://github.com/apache/buildstream-plugins/pull/62#discussion_r1585492629
########## src/buildstream_plugins/sources/cargo.py: ########## @@ -75,6 +85,10 @@ from buildstream import Source, SourceFetcher, SourceError from buildstream import utils +import dulwich Review Comment: > For buildstream-plugins, we prefer to have no dependencies outside of the standard library. Maybe we can just move this as a new plugin to the experimental plugins repo? The git plugin that is actually used is already there and uses dulwich as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
