gtristan commented on code in PR #62: URL: https://github.com/apache/buildstream-plugins/pull/62#discussion_r1574257654
########## src/buildstream_plugins/sources/cargo.py: ########## @@ -75,6 +85,10 @@ from buildstream import Source, SourceFetcher, SourceError from buildstream import utils +import dulwich Review Comment: For buildstream-plugins, we prefer to have no dependencies outside of the standard library. Some exceptions have been made for tomli and requests, which we expect to be API stable, any unstable APIs we rely on can cause BuildStream projects to be dependent on host specific configurations, and even worse, when junctions are involved this can result in being painted into a corner where multiple projects require different versions of the same external python libraries, and thus cannot be built. This has caused much issues specifically with `dulwich` being used by the `git_repo` plugin in bst-plugins-experimental, which appears to be a wildly changing API and the specific version of dulwich to use is not very clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
