gtristan commented on code in PR #1994:
URL: https://github.com/apache/buildstream/pull/1994#discussion_r2072623944
##########
tests/frontend/show.py:
##########
@@ -553,6 +554,64 @@ def test_strict_dependencies(cli, datafiles, target,
expected_state):
assert states[target] == expected_state
+# This tests that cache keys behave as expected when
+# dependencies have been specified as `strict` and
+# when building in strict mode.
+#
+# This test will:
+#
+# * Build the target once (and assert that it is cached)
+# * Modify some local files which are imported
+# by an import element which the target depends on
+# * Assert that the cached state of the target element
+# is as expected
+#
+# We run the test twice, once with an element which strict
+# depends on the changing import element, and one which
+# depends on it regularly.
+#
[email protected](os.path.join(DATA_DIR, "project"))
[email protected](
+ "target, expected_digests",
+ [
+ ("target.bst", {
Review Comment:
As mentioned in my new comments, let's take care to:
* Have one test which cares about what the digests are
* This test is parametrized (and uses the `ids` especially since it produces
these super long test names)
* Not use parametrization for cases where the digest value itself doesn't
matter.
This is just about only testing what is relevant to test, and keeping
overall test time to a minimum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
