gtristan commented on PR #1994: URL: https://github.com/apache/buildstream/pull/1994#issuecomment-2849238459
Overall, thanks for updating the tests, its a great update and sorry I didn't get back to it sooner. There are some more comments which should be straight forward to address, and one comment which I find concerning, regarding whether we are actually reporting the *correct* digest of the content and not the digest of the artifact envelope: https://github.com/apache/buildstream/pull/1994#discussion_r2072625739 You will also need to apply https://github.com/apache/buildstream/pull/1997/commits/51227aca4085a0d8fcb28f6941f0c43ce2269de3 to this branch in order to pass CI, since upstream setuptools decided to break the whole world. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
