gtristan commented on code in PR #2005:
URL: https://github.com/apache/buildstream/pull/2005#discussion_r2094397674
##########
src/buildstream/_scheduler/scheduler.py:
##########
@@ -371,7 +371,7 @@ def _sched_queue_jobs(self):
# Pull elements forward through queues
elements = []
- for queue in queues:
+ for queue in self.queues:
Review Comment:
Ok... I've done some mental gymnastics and I agree with your statement :)
What I would like to see here is:
* Rename the local `queues` variable to something more explicit, perhaps
`queues_to_process`
* At least slightly elaborate on the comment *"Pull elements forward through
queues"*
* Perhaps something like *"Pull elements forward through all queues,
regardless of whether we are processing those queues"*
* Maybe even a little explanation, like *"We need to propagate elements
through all queues even if we are not processing post-imperative queues, so
that we do end up processing the jobs we need to"*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
