gtristan commented on PR #2005:
URL: https://github.com/apache/buildstream/pull/2005#issuecomment-2888803996
Can we add a test here ?
I think that we can potentially test correct behavior, as described in the
comments of #1787, by constructing a test which:
* Has an artifactshare
* Has a build which fails
* Test that the failed build exists in the artifact share after the failed
`bst build` call
* And/or use the `cli.get_pushed_elements()` checker to also verify the
build log
I think we already have a similar test in
`tests/integration/cachedfail.py::test_push_cached_fail()`, perhaps this
requires constructing a dependency chain which fails the existing test but
passes with this change applied ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
