juergbi commented on PR #2035: URL: https://github.com/apache/buildstream/pull/2035#issuecomment-3116875644
> ## Connecting the dots > > Something I that we'll absolutely need is a way for scripts to piece together the data in interesting ways, this means we need reliable ways to make references to other data in the JSON output. I fully agree. In addition to making sure that dependencies are fully qualified, also the element definitions need to be fully qualified. And I think we want to make sure that they use the same structure. As far as I can tell, this branch currently uses `_get_full_name()` in both places, which results in qualified strings such as `foo.bst:bar.bst` when junctions are involved. This seems perfectly reasonable to me. I think if we want to extract the junction part to a separate JSON member, we should do it also in element definitions for consistency. However, I suspect that the current approach with a single colon-separated string will be more convenient in practice, as there will be no need to do any string manipulation just for 'connecting the dots'. And it also matches `bst show`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
