gtristan commented on PR #2035: URL: https://github.com/apache/buildstream/pull/2035#issuecomment-3119659971
> One thing to note: I added a top level `defaults` field which contains the default environment loaded per the default configuration so we don't have to duplicate redundant information within. Happy to remove this if you think the previous duplicated way is still better though. It is interesting to consider the optimization this might provide for external tooling which wants to consider the env vars of many elements yes. I wouldn’t want to frame such an optimization in terms of project defaults though, as this would imply the user repeats the composition algorithm, which is a bit more complex than just elements overriding project settings. Also, we need to construct data which can equally be obtained by loading a local buildstream project, or, by downloading artifacts, so we really want to be dealing with only resolved element data which can potentially be encoded into artifact metadata (not all data is currently included in artifact metadata, but that is an interesting thing to enrich). Perhaps there is some semantic we could have to reduce redundant data in the output, especially when the requested output fields include things which typically repeat (like env vars), I think it would be also fine to punt that optimization down the road, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
