abderrahim commented on code in PR #2036:
URL: https://github.com/apache/buildstream/pull/2036#discussion_r2296709460
##########
src/buildstream/buildelement.py:
##########
@@ -286,7 +306,18 @@ def configure_sandbox(self, sandbox):
sandbox.set_work_directory(command_dir)
# Setup environment
- sandbox.set_environment(self.get_environment())
+ env = self.get_environment()
+
+ # Add "CAS digest" environment variables
+ sorted_envs = sorted(self.__digest_environment)
+ for digest_variable in sorted_envs:
+ element_list = [element for element, _ in
self.__digest_environment[digest_variable]]
+ with self.subsandbox(sandbox) as subsandbox:
+ self.stage_dependency_artifacts(subsandbox, element_list)
Review Comment:
We should probably put this inside a timed activity with
`silent_nested=True`. Logging is a bit too verbose (and confusing) right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
