abderrahim commented on code in PR #2036:
URL: https://github.com/apache/buildstream/pull/2036#discussion_r2328705388
##########
src/buildstream/element.py:
##########
@@ -1453,7 +1453,11 @@ def _prepare_sandbox(self, scope, shell=False,
integrate=True, usebuildtree=Fals
# Stage what we need
self.__stage(sandbox)
else:
- self.__configure_sandbox(sandbox)
+ # Runtime shell or `bst artifact checkout`
+
+ # Don't call `configure_sandbox()` as that may attempt to
construct subsandboxes
+ # with build dependencies and we're not setting up a build
sandbox.
+ sandbox.set_environment(self.get_environment())
Review Comment:
I think it makes sense to squash this commit into the one before it.
##########
src/buildstream/buildelement.py:
##########
@@ -268,6 +278,16 @@ def get_unique_key(self):
}
dictionary["layout"] = layout_key
+ # Specify the layout in the key, if buildstream is to generate an
environmenta
Review Comment:
typo: "environmenta"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
