deitch opened a new pull request, #91:
URL: https://github.com/apache/buildstream-plugins/pull/91

   The `docker.py` docker source plugin was failing on 2 issues:
   
   * no authentication. It ignored `$DOCKER_CONFIG/config.json` (or the default 
`~/.docker/config.json`) to get credentials.
   * no support for the up to date oci types that match the docker types.
   
   This meant:
   
   * private images on `ghcr.io` or docker hub or anywhere failed
   * recently created and pushed images failed, as they often use the OCI types
   
   I added both of these. I already use it in an in-house project, figured we 
should upstream.
   
   If there are tests to add, please point me in the direction, happy to do so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to