joshua-zivkovic commented on code in PR #2099:
URL: https://github.com/apache/buildstream/pull/2099#discussion_r2675867018
##########
src/buildstream/source.py:
##########
@@ -927,7 +929,16 @@ def set_ref(self, ref, node):
"""
raise ImplError("Source plugin '{}' does not implement
set_ref()".format(self.get_kind()))
- def track(self, *, previous_sources_dir: Optional[str] = None) ->
SourceRef:
+ def load_source_provenance(self, node: MappingNode) -> None:
+ raise ImplError("Source plugin '{}' does not implement
load_source_provenance()".format(self.get_kind()))
+
+ def get_source_provenance(self) -> SourceProvenance:
+ raise ImplError("Source plugin '{}' does not implement
get_source_provenance()".format(self.get_kind()))
+
+ def set_source_provenance(self, source_provenance: SourceProvenance):
+ raise ImplError("Source plugin '{}' does not implement
set_source_provenance()".format(self.get_kind()))
+
+ def track(self, *, previous_sources_dir: Optional[str] = None) ->
(SourceRef, SourceProvenance):
Review Comment:
For now I've gone with combining the old and new return signatures
(https://github.com/apache/buildstream/pull/2099/files#diff-48200ef302e5d841cce81834e8879a65e59db922a22605b9d7fa16b4dd5c7067R941)
and added some logic to unpackage it appropriately
(https://github.com/apache/buildstream/pull/2099/files#diff-48200ef302e5d841cce81834e8879a65e59db922a22605b9d7fa16b4dd5c7067R1811).
I believe that's all that's required to not break the API here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
