joshua-zivkovic commented on PR #2099: URL: https://github.com/apache/buildstream/pull/2099#issuecomment-3789577792
> Somewhat of a nit but it seems we're mixing two terms for the same thing. I'm not sure whether "source provenance field" or "source provenance attribute" is a better fit. However, whatever we choose, we should be consistent to avoid confusion. Or is there a semantic distinction that I'm overlooking? I've noticed this too and haven't got a fixed opinion on which we use. I was just using "attributes" since https://github.com/apache/buildstream/issues/2069 uses the term. I'm not seeing any deciding usage in the docs. In context of errors that already exist, it seems "attribute" reads better than "field", to me at least, but that's just how I've been reading it all this time anyway. I'll change up the error messages as per your suggestions and make the term used consistent based on what reads best from there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
