abderrahim commented on code in PR #2179:
URL: https://github.com/apache/buildstream/pull/2179#discussion_r3837921554
##########
src/buildstream/_frontend/app.py:
##########
@@ -750,8 +750,19 @@ def _handle_failure(self, element, task, failure):
elif choice == "log":
with open(failure.logfile, "r", encoding="utf-8") as
logfile:
content = logfile.read()
+ # click.echo_via_pager needs a usable TERM to run an
interactive
+ # pager. When TERM is unset (Fedora 44 CI), the pager
returns
Review Comment:
I think the CI needs to change rather than this.
IIUC, we shouldn't be getting into this part of the code with a dumb
terminal. So the tests are probably forcing interactive mode even though it's a
dumb terminal, and need to be fixed there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
