nathanwilliams-ct commented on code in PR #2179:
URL: https://github.com/apache/buildstream/pull/2179#discussion_r3842033879
##########
tests/integration/interactive_build.py:
##########
@@ -36,6 +36,13 @@
def build_session(integration_cache, datafiles, element_name):
project = str(datafiles)
+ # Interactive tests need a usable TERM so tools like click's pager (less)
+ # run interactively. Containers used for CI often leave TERM unset even
+ # when pexpect allocates a PTY.
+ env = os.environ.copy()
Review Comment:
Rather than forcing the test environment to be something that Buildstream
expects, would it be better to adjust Buildstream to handle this? We want
Buildstream to work in as many environments as possible right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
