abderrahim commented on code in PR #2172:
URL: https://github.com/apache/buildstream/pull/2172#discussion_r3870745595
##########
src/buildstream/_cas/cascache.py:
##########
@@ -286,7 +286,7 @@ def fetch_directory(self, remote, dir_digest):
"Failed to fetch directory tree {}: {}:
{}".format(dir_digest.hash, e.code().name, e.details())
) from e
- required_blobs = self.required_blobs_for_directory(dir_digest)
+ required_blobs = self.required_blobs_for_directory(dir_digest,
_fetch_tree=False)
Review Comment:
I wonder if it would be better to drop the fetch tree from this function,
and rely on the one in `required_blobs_for_directory()`. I'll try to dig deeper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
