abderrahim commented on code in PR #2172:
URL: https://github.com/apache/buildstream/pull/2172#discussion_r3906651188
##########
src/buildstream/_cas/cascache.py:
##########
@@ -286,7 +286,7 @@ def fetch_directory(self, remote, dir_digest):
"Failed to fetch directory tree {}: {}:
{}".format(dir_digest.hash, e.code().name, e.details())
) from e
- required_blobs = self.required_blobs_for_directory(dir_digest)
+ required_blobs = self.required_blobs_for_directory(dir_digest,
_fetch_tree=False)
Review Comment:
Actually, my comment isn't correct. In this function we fetch from the
remote but `required_blobs_for_directory()` only tries to fetch from the cache
storage-service if it's configured.
So this is indeed an optimisation, but only for the specific use case when
using a storage-service for the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
