juergbi commented on code in PR #2129: URL: https://github.com/apache/buildstream/pull/2129#discussion_r4237341667
########## tests/integration/checkoutbuildtrees.py: ########## @@ -0,0 +1,271 @@ +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# Pylint doesn't play well with fixtures and dependency injection from pytest +# pylint: disable=redefined-outer-name + +import os +import tarfile + +import pytest + +from buildstream._testing import cli, cli_integration, Cli # pylint: disable=unused-import +from buildstream.exceptions import ErrorDomain +from buildstream._testing._utils.site import HAVE_SANDBOX + +from tests.testutils import create_artifact_share + +pytestmark = pytest.mark.integration + + +DATA_DIR = os.path.join(os.path.dirname(os.path.realpath(__file__)), "project") + + +# +# Checkout the buildtree and the buildroot of a build element +# [email protected](DATA_DIR) [email protected](not HAVE_SANDBOX, reason="Only available with a functioning sandbox") [email protected]("hardlinks", [False, True], ids=["copy", "hardlinks"]) +def test_checkout_buildtree(cli_integration, tmpdir, datafiles, hardlinks): + project = str(datafiles) + element_name = "build-shell/buildtree.bst" + checkout = os.path.join(str(tmpdir), "checkout") + + res = cli_integration.run(project=project, args=["--cache-buildtrees", "always", "build", element_name]) + res.assert_success() + + args = ["artifact", "checkout", "--buildtree", "--directory", checkout, element_name] + if hardlinks: + args += ["--hardlinks"] + res = cli_integration.run(project=project, args=args) + res.assert_success() + + # Only the content of the build directory is checked out + assert os.listdir(checkout) == ["test"] + with open(os.path.join(checkout, "test"), encoding="utf-8") as f: + assert f.read() == "Hi\n" + + checkout = os.path.join(str(tmpdir), "checkout-buildroot") + args = ["artifact", "checkout", "--buildroot", "--directory", checkout, element_name] + if hardlinks: + args += ["--hardlinks"] + res = cli_integration.run(project=project, args=args) + res.assert_success() + + # The whole build sandbox is checked out, including the build directory + with open( + os.path.join(checkout, "buildstream", "test", "build-shell", "buildtree.bst", "test"), encoding="utf-8" + ) as f: + assert f.read() == "Hi\n" + assert os.path.exists(os.path.join(checkout, "bin", "sh")) Review Comment: This fails in CI because it's a symlink to `/bin/busybox`, which doesn't exist on the host. ```suggestion assert os.path.lexists(os.path.join(checkout, "bin", "sh")) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
