zabetak commented on a change in pull request #884: [CALCITE-2621] New rule:
SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate) (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/884#discussion_r261568130
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/JoinToCorrelateRule.java
##########
@@ -77,10 +83,19 @@ protected JoinToCorrelateRule(RelFactories.FilterFactory
filterFactory) {
this(RelBuilder.proto(Contexts.of(filterFactory)));
}
+ /**
+ * Creates a JoinToCorrelateRule for a certain sub-class of
+ * {@link org.apache.calcite.rel.core.Join}
+ */
+ public JoinToCorrelateRule(Class<? extends Join> clazz,
Review comment:
If we can treat any kind of join with this rule then we shouldn't have to
perform casts afterwards. I am OK with adding such a constructor if we can
achieve that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
