zabetak commented on a change in pull request #884: [CALCITE-2621] New rule:
SemiJoinToCorrelateRule (SemiJoin => LogicalCorrelate) (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/884#discussion_r261638335
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/JoinToCorrelateRule.java
##########
@@ -127,7 +142,7 @@ public void onMatch(RelOptRuleCall call) {
relBuilder.build(),
correlationId,
requiredColumns.build(),
- SemiJoinType.of(join.getJoinType()));
+ join instanceof SemiJoin ? SemiJoinType.SEMI :
SemiJoinType.of(join.getJoinType()));
Review comment:
I didn't have a function in mind but it can do the job.
@julianhyde, I've seen that you had some concerns against a lamda function
in the Jira issue so I am waiting for your input. From my perspective, if we
keep this function and its configuration private I don't see a real problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
