danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r276601185
########## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ########## @@ -3734,6 +3740,13 @@ private Exists(RelNode r, boolean indicator, boolean outerJoin) { this.outerJoin = outerJoin; } } + + /** Check if it is the join whose condition is based on column equality. */ + public static boolean isEquiJoin(Join join) { + return join.isNonCorrelateSemiJoin() + || join instanceof EnumerableHashJoin + || join instanceof EnumerableMergeJoin; + } Review comment: There are 2 rules that use this method to make some decision when planning, this method returns what the original EquiJoin is, cause now the join.analyzeCondition().isEqui() has wider scope that this method returns. I thought maybe we should move the logic to the rules or tweak the rules logic. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services