danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279149207
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.java
##########
@@ -161,31 +142,48 @@ public static EnumerableJoin create(
} else {
rowCount += rightRowCount;
}
- return planner.getCostFactory().makeCost(rowCount, 0, 0);
+ if (isNonCorrelatedSemiJoin()) {
Review comment:
If it is a semi-join type, It is definitely not correlated in the current
implementation, but i still want to keep this check, cause i don't want it to
be a implicit rule that guaranteed by the internal design, after all, correlate
counts to SEMI-JOIN, although we never decorrelate to such join type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
