hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279618398
##########
File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java
##########
@@ -94,6 +142,37 @@ public JoinRelType cancelNullsOnRight() {
return this;
}
}
+
+ /** Transform this JoinRelType to CorrelateJoinType. **/
+ public CorrelateJoinType toLinq4j() {
+ switch (this) {
+ case INNER:
+ return CorrelateJoinType.INNER;
+ case LEFT:
+ return CorrelateJoinType.LEFT;
+ case SEMI:
+ return CorrelateJoinType.SEMI;
+ case ANTI:
+ return CorrelateJoinType.ANTI;
+ }
+ throw new IllegalStateException(
+ "Unable to convert " + this + " to CorrelateJoinType");
+ }
Review comment:
Do we need this function? Can't we just pass JoinRelType directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
