hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r285290030
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdDistinctRowCount.java
##########
@@ -140,35 +139,13 @@ public Double getDistinctRowCount(Filter rel,
RelMetadataQuery mq,
public Double getDistinctRowCount(Join rel, RelMetadataQuery mq,
ImmutableBitSet groupKey, RexNode predicate) {
- if (predicate == null || predicate.isAlwaysTrue()) {
- if (groupKey.isEmpty()) {
- return 1D;
- }
- }
return RelMdUtil.getJoinDistinctRowCount(mq, rel, rel.getJoinType(),
groupKey, predicate, false);
}
public Double getDistinctRowCount(SemiJoin rel, RelMetadataQuery mq,
Review comment:
Let's deprecate this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
