danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r281087609
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/JoinToCorrelateRule.java
##########
@@ -64,10 +63,10 @@
public class JoinToCorrelateRule extends RelOptRule {
/**
- * Function to extract the {@link org.apache.calcite.sql.SemiJoinType}
parameter
+ * Function to extract the {@link JoinRelType} parameter
* for the creation of the {@link
org.apache.calcite.rel.logical.LogicalCorrelate}
*/
- private final Function<Join, SemiJoinType> semiJoinTypeExtractor;
+ private final Function<Join, JoinRelType> semiJoinTypeExtractor;
Review comment:
I agree, will remove `semiJoinTypeExtractor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
