danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279990063
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/JoinToCorrelateRule.java
##########
@@ -77,27 +75,19 @@
*/
public static final JoinToCorrelateRule JOIN =
new JoinToCorrelateRule(LogicalJoin.class, RelFactories.LOGICAL_BUILDER,
- "JoinToCorrelateRule", join ->
SemiJoinType.of(join.getJoinType()));
+ "JoinToCorrelateRule", Join::getJoinType);
@Deprecated // to be removed (should use JOIN instead), kept for backwards
compatibility
public static final JoinToCorrelateRule INSTANCE = JOIN;
- /**
- * Rule that converts a {@link org.apache.calcite.rel.core.SemiJoin}
- * into a {@link org.apache.calcite.rel.logical.LogicalCorrelate}
- */
- public static final JoinToCorrelateRule SEMI =
- new JoinToCorrelateRule(SemiJoin.class, RelFactories.LOGICAL_BUILDER,
Review comment:
I agree, add it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
