julianhyde commented on issue #1443: HiveSqlDialect unparse Interger type as Int in order to be compatible for hive1.x URL: https://github.com/apache/calcite/pull/1443#issuecomment-528492565 There's some refactoring to be done. There is already a `SqlDialect.getCastSpec` method. That method needs to be documented (and if necessary refactored). It's crazy that your fix works by overriding `SqlDialect.unparseCall` when there is already a `SqlDialect.getCastSpec`, and there a lot of other code in `SqlImplementor.toSql(RexProgram program, RexNode rex)`. As part of your fix, can you sort out this mess, and make it a bit better rather than a bit worse?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
