zabetak commented on a change in pull request #1610: [CALCITE-3525] 
RexSimplify: eliminate redundant rex calls in OR
URL: https://github.com/apache/calcite/pull/1610#discussion_r357927964
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexExecutable.java
 ##########
 @@ -85,7 +85,7 @@ public void reduce(RexBuilder rexBuilder, List<RexNode> 
constExps,
         reducedValues.add(
             rexBuilder.makeLiteral(value.right, value.left.getType(), true));
       }
-    } catch (RuntimeException e) {
+    } catch (RuntimeException | AssertionError e) {
 
 Review comment:
   I don't think we should ever catch AssertionError. Can't we avoid this? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to