zabetak commented on a change in pull request #1610: [CALCITE-3525]
RexSimplify: eliminate redundant rex calls in OR
URL: https://github.com/apache/calcite/pull/1610#discussion_r358184718
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -1970,6 +1980,8 @@ public static void registerDefaultRules(RelOptPlanner
planner,
// Change the below to enable constant-reduction.
if (false) {
registerReductionRules(planner);
+ } else {
+ planner.addRule(ReduceExpressionsRule.FILTER_INSTANCE);
Review comment:
If we decide to enable `ReduceExpressionsRule.FILTER_INSTANCE` then we
should definitely refactor this piece of code possibly keeping only
`planner.addRule(ReduceExpressionsRule.FILTER_INSTANCE);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
