danny0405 commented on a change in pull request #1703: [CALCITE-2450] Normalize
RexCall predicates when computing digest
URL: https://github.com/apache/calcite/pull/1703#discussion_r362356189
##########
File path: core/src/main/java/org/apache/calcite/rex/RexCall.java
##########
@@ -155,15 +237,15 @@ private static boolean equalSansNullability(RelDataType
a, RelDataType b) {
&& x.startsWith(y);
}
- protected @Nonnull String computeDigest(boolean withType) {
+ protected @Nonnull String computeDigest(boolean withType, boolean
withNormalize) {
final StringBuilder sb = new StringBuilder(op.getName());
Review comment:
I would suggest to introduce a new config class for computing digest,
something like `computeDigest(RexCall.Config)` to give the interface better
extensibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
