vlsi commented on a change in pull request #1703: [CALCITE-2450] Normalize
RexCall predicates when computing digest
URL: https://github.com/apache/calcite/pull/1703#discussion_r362552325
##########
File path: core/build.gradle.kts
##########
@@ -41,6 +41,7 @@ dependencies {
api("com.fasterxml.jackson.core:jackson-annotations")
api("org.apache.calcite.avatica:avatica-core")
+ api("org.apiguardian:apiguardian-api")
Review comment:
Do you expect the same annotation to be used in Avatica and Calcite?
Does that mean the annotation should be declared in Avatica, and can be used
in Calcite only after Avatica is released? It does sound too complicated.
On the other hand, https://github.com/apiguardian-team/apiguardian is a
more-or-less clear dependency that has already been tested (e.g. it is used in
JUnit5).
In other words, `apiguardian-api` is already available (and it can be easily
used by other projects for consistent API declaration!) while Calcite's
annotation is nowhere near.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
