jcamachor commented on a change in pull request #1852: [CALCITE-3848]
Materialized view rewriting fails for mv consisting of group by on join keys
(Vineet Garg)
URL: https://github.com/apache/calcite/pull/1852#discussion_r390040676
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java
##########
@@ -636,7 +635,7 @@ protected MaterializedViewAggregateRule(RelOptRuleOperand
operand,
// Cannot rollup this aggregate, bail out
return null;
}
- rewritingMapping.set(k, queryAggregate.getGroupCount() +
aggregateCalls.size());
+ rewritingMapping.put(k, queryAggregate.getGroupCount() +
aggregateCalls.size());
final RexInputRef operand = rexBuilder.makeInputRef(input, k);
aggregateCalls.add(
// TODO: handle aggregate ordering
Review comment:
Not related to this patch, but this comment seems outdated since we handle
aggregate ordering below?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
